Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for console.assert #6302

Closed
wants to merge 1 commit into from
Closed

test: add tests for console.assert #6302

wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Contributor

@evanlucas evanlucas commented Apr 20, 2016 •
edited
Loading

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

There were previously no tests where console.assert failed

@evanlucas
test: add tests for console.assert
268a3bc 
There were previously no tests where console.assert failed
@evanlucas evanlucas added test Issues and PRs related to the tests. console Issues and PRs related to the console subsystem. labels Apr 20, 2016
@evanlucas
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2338/

@santigimeno
Copy link
Member

LGTM

3 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Apr 20, 2016

LGTM

@mscdex
Copy link
Contributor

mscdex commented Apr 20, 2016

LGTM

@Trott
Copy link
Member

Trott commented Apr 20, 2016

LGTM

jasnell pushed a commit that referenced this pull request Apr 22, 2016
@evanlucas @jasnell
test: add tests for console.assert
84ebf2b 
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 22, 2016

Landed in 84ebf2b

@jasnell jasnell closed this Apr 22, 2016
@evanlucas
Copy link
Contributor Author

Thanks @jasnell!

@evanlucas evanlucas deleted the addconsoleasserttests branch April 25, 2016 01:47
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
@evanlucas @joelostrowski
test: add tests for console.assert
89d75cb 
There were previously no tests where console.assert failed

PR-URL: nodejs#6302
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@evanlucas @jasnell
test: add tests for console.assert
591ebe7 
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@evanlucas
test: add tests for console.assert
fb44f5c 
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@evanlucas
test: add tests for console.assert
06e5faf 
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
console Issues and PRs related to the console subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@evanlucas @santigimeno @cjihrig @mscdex @Trott @jasnell @MylesBorins